[FIX] canvas: Fix link runtime state modeling #2591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add (and use as default) a `NoState` flag to account for no runtime execution state.
Codecov Report
@@ Coverage Diff @@
## master #2591 +/- ##
=======================================
Coverage 75.08% 75.08%
=======================================
Files 327 327
Lines 57669 57669
=======================================
Hits 43298 43298
Misses 14371 14371 |
astaric
reviewed
Sep 13, 2017
| #: A link is pending when it's sink node has not yet been notified | ||
| #: of a change (note that Empty|Pending is a valid state) | ||
| Pending = 2 | ||
| Pending = 4 |
There was a problem hiding this comment.
Is Pending a valid state or is it always Empty|Pending or Active|Pending?
There was a problem hiding this comment.
Let's say it is valid.
There was a problem hiding this comment.
I asked because it used to be marked with a dashed line (it was not active), but it is marked with a solid line in this PR (it is not empty). If the state does not occur normally by itself, it is not a problem.
astaric
approved these changes
Sep 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Links in workflow previews are rendered as dotted lines. This is due to workflow mode's inability to account for the possibility that it has no associated runtime execution state.
Description of changes
Add (and use as default) a
NoStateflag to account for no runtime execution state. Style the graphical presentation accordingly.Includes